CA-396751/py3: Test changes in rrdd.API.update(), fix pyright
#5938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernhardkaindl
requested review from
edwintorok,
lindig,
MarkSymsCtx and
liulinC
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
bernhardkaindl
force-pushed
the
py3_pytest_rrdd_api_data_update
branch
from
2ecc25b to
5e40c09
Compare
bernhardkaindl
changed the title
bernhardkaindl
changed the title
rrdd.API.update(), add typing stubs
bernhardkaindl
changed the title
rrdd.API.update(), add typing stubsrrdd.API.update(), fix pyright
bernhardkaindl
changed the title
rrdd.API.update(), fix pyrightrrdd.API.update(), fix pyright
liulinC
approved these changes
Aug 15, 2024
|
Approve given no product code change, just for unitttests |
edwintorok
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test changes by the recent update of rrdd.py for CI
No code change: Only adds a new test case and fixes pyright
Please approve this PR to fix CI for merging
masterinto feature/py3:With commit b33ceee of #5915 (CA-396751: write updated RRDD data before headers)
master/ocaml/xcp-rrdd/scripts/rrdd/rrdd.py#L315 was changed slightly yesterday by #5915,
In this PR:
Add the missing test that will from now on cover changes to the update() method of https://github.com/xapi-project/xen-api/blob/master/ocaml/xcp-rrdd/scripts/rrdd/rrdd.py.
Also add the missing typing stubs to fix
pyrightchecks.Next step for @liulinC:
After this PR is merged into
feature/py3, CI of #5937 is fixed by closing #5937 and immediately re-opening #5937 to re-base the CI run of #5937 on top of the (then) updatedfeature/py3branch.